closed issue or pr will not run chat-ops anymore (#61)

.github/governance.yml

@@ -20,20 +20,6 @@ issue:
       multiple: false
       needs: true
 
-    - prefix: area
-      list: [ "security", "documentation", "chat-ops", "labels", "captures", "permission" ]
-      multiple: true
-      needs:
-        comment: |
-          @$AUTHOR: There are no area labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. **If you are unsure what to do you can ignore this!**
-
-          * `/area labels`
-          * `/area chat-ops`
-          * `/area documentation`
-          * `/area security`
-          * `/area captures`
-          * `/area permission`
-
   chat_ops:
     - cmd: /close
       type: close

.github/labels.yml

@@ -10,9 +10,6 @@
 - color: cc40d8
   name: needs/kind
   description: Needs kind label
-- color: cc40d8
-  name: needs/area
-  description: Needs area label(s)
 - color: cc40d8
   name: needs/priority
   description: Needs a priority label
@@ -46,20 +43,6 @@
   name: kind/dependencies
   description: Pull requests that update a dependency file
 
-# Area
-- color: fbca04
-  name: area/security
-- color: fbca04
-  name: area/documentation
-- color: fbca04
-  name: area/chat-ops
-- color: fbca04
-  name: area/labels
-- color: fbca04
-  name: area/captures
-- color: fbca04
-  name: area/permission
-
 # Priority
 - color: d93f0b
   name: priority/urgent-now

__tests__/ignore.test.ts

@@ -96,6 +96,26 @@ describe('issue_comment', () => {
     set('issue_comment', 'deleted', 'User')
     await expectIgnore(true)
   })
+
+  it('should ignore created but closed', async () => {
+    set('issue_comment', 'created', 'User', {
+      pull_request: {
+        number: 1,
+        state: 'closed'
+      }
+    })
+    await expectIgnore(true)
+  })
+
+  it('should ignore created but closed', async () => {
+    set('issue_comment', 'created', 'User', {
+      issue: {
+        number: 1,
+        state: 'closed'
+      }
+    })
+    await expectIgnore(true)
+  })
 })
 
 describe('pull_request', () => {

__tests__/main.test.ts

@@ -103,14 +103,15 @@ describe('getGovernance', () => {
     jest.setTimeout(10000)
     github.context.payload = {
       issue: {
-        number: 1
+        number: 1,
+        state: 'open'
       }
     }
 
     const {getGovernance} = require('../src/main')
     const governance = await getGovernance()
 
-    expect(governance?.labels?.length).toBe(3)
+    expect(governance?.labels?.length).toBe(2)
   })
 
   it('should be pull request', async function () {
@@ -134,14 +135,15 @@ describe('getGovernance', () => {
           id: 1
         },
         issue: {
-          number: 1
+          number: 1,
+          state: 'open'
         }
       }
 
       const {getGovernance} = require('../src/main')
       const governance = await getGovernance()
 
-      expect(governance?.labels?.length).toBe(3)
+      expect(governance?.labels?.length).toBe(2)
     })
 
     it('should be pull request', async function () {

src/ignore.ts

@@ -58,6 +58,22 @@ async function ignoreBot(): Promise<boolean> {
   return false
 }
 
+/**
+ * Closed issue and pull_request should not trigger governance
+ */
+function ignoreClosed(): boolean {
+  const payload = github.context.payload
+  if (payload?.pull_request?.state === 'closed') {
+    return true
+  }
+
+  if (payload?.issue?.state === 'closed') {
+    return true
+  }
+
+  return false
+}
+
 /**
  * To prevent mistakes, this will ignore invalid workflow trigger
  */
@@ -66,6 +82,10 @@ export default async function (): Promise<boolean> {
     return true
   }
 
+  if (ignoreClosed()) {
+    return true
+  }
+
   if (await ignoreBot()) {
     return true
   }