fix(ui-ux): contact tab bug fixes #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for defimetascan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Steps:
|
|
cannot add array values in write proxy |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
its not related to chain as using remix its working fine |
You're right, its an error caused by how the input arguments were being processed, added into list of fixed issues |
Comment on lines
84
to
86
| if (inputType === "uint256") { | ||
| return parseEther(value); | ||
| } |
There was a problem hiding this comment.
Lets remove this,
fullstackninja864
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Under the contracts tab, using
MarbleLsdV1andMarbleLsdProxycontract:Which issue(s) does this PR fixes?:
Fixes #
Additional comments?:
Most of the write methods can only tested with the contract creator's address
Developer Checklist: