Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security): adding security headers to Netlify #114

Merged
merged 15 commits into from
Aug 17, 2022

Conversation

Abhishekkochar
Copy link
Contributor

@Abhishekkochar Abhishekkochar commented Aug 16, 2022

What this PR does / why we need it:

As part of #84, adding in security headers but not CSP for now. Will continue to look into the right CSP headers.

Which issue(s) does this PR fixes?:

Additional comments?:

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for liquidity-dfi ready!

Name Link
🔨 Latest commit ef3c79f
🔍 Latest deploy log https://app.netlify.com/sites/liquidity-dfi/deploys/62fc5d26ca249000082270e4
😎 Deploy Preview https://deploy-preview-114--liquidity-dfi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@birthdayresearch-bot birthdayresearch-bot added the kind/fix Fix a bug label Aug 16, 2022
@Abhishekkochar
Copy link
Contributor Author

@gjj CSP is still pending. I need to research more on what we need in terms of CSP. Others have been implemented.
Screen Shot 2022-08-17 at 3 36 45 PM

@Abhishekkochar Abhishekkochar marked this pull request as ready for review August 17, 2022 05:24
@gjj gjj changed the title fix: issue #84 chore(security): adding security headers to Netlify Aug 17, 2022
@birthdayresearch-bot birthdayresearch-bot added kind/chore Non feature change and removed kind/fix Fix a bug labels Aug 17, 2022
@Abhishekkochar Abhishekkochar merged commit c22838b into main Aug 17, 2022
@Abhishekkochar Abhishekkochar deleted the abhishek/issue84 branch August 17, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants