Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-ux): rename dUSDT to ex_USDT #1937

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

chloezxyy
Copy link
Contributor

@chloezxyy chloezxyy commented Jul 18, 2024

What this PR does / why we need it:

  • Created a function to rename token displaySymbol from dUSDT to ex_USDT in all UI components.
  • The url params are not updated
  • Update token e2e test file to display ex_USDT token
  • For value display, it will be renamed to USD

Which issue(s) does this PR fixes?:

Fixes #

Sample Links & Screenshots:

Link:

Desktop Screenshot
Mobile Screenshot

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on multiple web browsers
  • Tested responsiveness (e.g, iPhone, iPad, Desktop)
  • No console errors
  • Unit tests*
  • Added e2e tests*

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for defi-scan ready!

Name Link
🔨 Latest commit f2fd3f5
🔍 Latest deploy log https://app.netlify.com/sites/defi-scan/deploys/669f2a02a4588f00089f9a59
😎 Deploy Preview https://deploy-preview-1937--defi-scan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chloezxyy chloezxyy self-assigned this Jul 19, 2024
@chloezxyy chloezxyy changed the title chore(ui-ux): rename dUSDT to csUSDT chore(ui-ux): rename dUSDT to ex_USDT Jul 22, 2024
@@ -89,7 +90,8 @@ function TokenDetailsItem(props: {
data-testid={props.testId}
>
<span className="flex items-center dark:text-gray-400">
<TokenIcon className="mr-2 w-4 h-4" /> {props.displaySymbol}
<TokenIcon className="mr-2 w-4 h-4" />{" "}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use margin here, instead of space

Copy link
Contributor Author

@chloezxyy chloezxyy Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants