Update package.json for using the right cli arch while building electron-app #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-app. I recognized a problem while using the "arch": ["x64", "arm64", "universal"] in package.json for electron-app. I don't think it uses the different cli arch for building the different electron-app arch. I think it must be selected from ../scripts/prebuild.js -> x64 cli for x64 desktop app and arm cli for arm desktop app. -> changes of prebuild.js follows... Pardon me, if my changes coming the wrong way - it's my first time to change scripts by using a fork of a repository...
Martin8617
referenced
this pull request
Jun 28, 2024
* update(core): added mac universal build and updated release app names * Update release-builds.yml Signed-off-by: Harsh R <[email protected]> --------- Signed-off-by: Harsh R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recognized a problem while using the "arch": ["x64", "arm64", "universal"] in package.json for electron-app. I don't think it uses the different cli arch for building the different electron-app arch. I think it must be selected from ../scripts/prebuild.js -> x64 cli for x64 desktop app and arm cli for arm desktop app. -> changes of prebuild.js follows...
Pardon me, if my changes coming the wrong way - it's my first time to change scripts by using a fork of a repository...
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
It compares the cli arch with the same arch of the electron-builder
Which issue(s) does this PR fixes?:
While using PC with x64 or arm64 architecture the running cli must be the same as the desktop-app is.
Fixes #
Additional comments?:
This PR goes together with the changes in "../scripts/prebuild.js"