Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update performance tables scripts #39

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

edenjenzohar
Copy link
Collaborator

Re-running the performance tables scripts for the rebuttal.
We should think about converting these two notebooks into a script that receives the raw data created by run_task.py and saves the figure in the paper.

@yoavkt
Copy link
Collaborator

yoavkt commented Aug 22, 2024

Correct, what we need to do is add a module named displays or something along those lines.
Do we want to do this in this PR?

@edenjenzohar
Copy link
Collaborator Author

no i think the refactoring should be done in a separate PR

Copy link
Collaborator

@yoavkt yoavkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@yoavkt yoavkt self-requested a review August 28, 2024 14:32
@mmdanziger mmdanziger merged commit eb5be64 into main Sep 18, 2024
6 checks passed
@mmdanziger mmdanziger deleted the Update_performance_tables_scripts branch September 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants