Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch encoder #34

Merged
merged 10 commits into from
Aug 18, 2024
Merged

Torch encoder #34

merged 10 commits into from
Aug 18, 2024

Conversation

yoavkt
Copy link
Collaborator

@yoavkt yoavkt commented Aug 12, 2024

We added the ability to encode bert based models

edenjenzohar
edenjenzohar approved these changes Aug 18, 2024
View reviewed changes
Copy link
Collaborator

@edenjenzohar edenjenzohar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! small question regarding the test

gene_benchmark/tests/test_encoder.py Show resolved Hide resolved
@yoavkt yoavkt merged commit 8812ddf into main Aug 18, 2024
6 checks passed
@yoavkt yoavkt deleted the torch_encoder branch August 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenjenzohar edenjenzohar edenjenzohar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoavkt @edenjenzohar