Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threshold for categorical tasks #27

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Conversation

edenjenzohar
Copy link
Collaborator

This PR adds a thresholding for categorical tasks, taking out the classes that have low representation, under the threshold value. This is important for the model to create kfolds properly, with equal representation of each class in every fold.

@edenjenzohar edenjenzohar requested a review from yoavkt July 9, 2024 09:46
Copy link
Collaborator

@yoavkt yoavkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test for the ability. Also small modification for the documentation.

gene_benchmark/tasks.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@yoavkt yoavkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add an additional test but its not a must.

gene_benchmark/tests/test_tasks.py Show resolved Hide resolved
@edenjenzohar edenjenzohar merged commit 1516a70 into main Jul 17, 2024
6 checks passed
@edenjenzohar edenjenzohar deleted the add_th_to_categorical branch July 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants