Tokenizer's default behavior on unknown token #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2024 12:14
mosheraboh
reviewed
Oct 13, 2024
| @@ -30,6 +30,7 @@ def __init__( | |||
| validate_ends_with_eos: Optional[bool] = True, | |||
| eos: Optional[str] = "<EOS>", | |||
| verbose: Optional[bool] = False, | |||
| on_unknown_default_value: Optional[str] = None, | |||
There was a problem hiding this comment.
Why None? set it directly to "warn".
Lets remove the option to set it to None also in the other function and just support "warn" or "raise"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support a configurable default value for the tokenizer op. Meaning we can change the default behavior of each instance, additionally to override it in the
__call__()function itself.