implement hdf5 dataset reader op #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagiPolaczek
previously approved these changes
May 30, 2024
|
|
||
| class OpReadHDF5(OpBase): | ||
| """ | ||
| Op reading data from hd5f based dataset |
| # store input | ||
| self._data_filename = data_filename | ||
| self._columns_to_extract = columns_to_extract | ||
| self._rename_columns = rename_columns if rename_columns is not None else {} |
There was a problem hiding this comment.
(avoiding mutable default values)
There was a problem hiding this comment.
I think we can use frozen dict here as well
| self._key_index = key_index | ||
| self._key_column = key_column | ||
|
|
||
| self._h5 = h5py.File(self._data_filename, "r") |
There was a problem hiding this comment.
Seeing that I was concern that we load the entire file into memory, but seems not:
https://stackoverflow.com/questions/40449659/does-h5py-read-the-whole-file-into-memory
| if self._columns_to_extract is None: | ||
| self._columns_to_extract = list(self._h5.keys()) | ||
|
|
||
| self._num_samples = len(self._h5[self._columns_to_extract[0]]) |
There was a problem hiding this comment.
Hope this line doesn't load it into memory
Comment on lines
+154
to
+155
| def num_samples(self) -> int: | ||
| return self._num_samples |
There was a problem hiding this comment.
I don't see where you use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.