Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NDict (hopefully) lighter to import #342

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Make NDict (hopefully) lighter to import #342

merged 2 commits into from
Jan 22, 2024

Conversation

SagiPolaczek
Copy link
Collaborator

@SagiPolaczek SagiPolaczek commented Jan 18, 2024 •
edited
Loading

NOTE:

It might be the case that from torch import Tensor still runs "unnecessary" code.

mosheraboh
mosheraboh approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Lets check if we can avoid this import how.

@SagiPolaczek SagiPolaczek changed the title Make NDict lighter to import Make NDict (hopefully) lighter to import Jan 22, 2024
@SagiPolaczek SagiPolaczek merged commit 995d85a into master Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosheraboh mosheraboh mosheraboh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagiPolaczek @mosheraboh