Stabilize CICD #140
Closed
Stabilize CICD #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 1, 2024 16:01
SagiPolaczek
commented
Sep 1, 2024
Jenkinsfile
Outdated
| @@ -13,7 +13,7 @@ pipeline { | |||
| steps { | |||
| sh ''' | |||
| rm -rf test-reports/TEST-*.xml | |||
| jbsub -wait -out ccc_log.txt -queue x86_1h -mem 40g -cores "10+1" -require 'v100' ./run_all_unit_tests.sh 11.8 /dccstor/fuse_med_ml/fuse-drug/cicd/envs/ | |||
| jbsub -wait -out ccc_log.txt -queue x86_1h -mem 40g -cores "10+1" -require 'v100' ./run_all_unit_tests.sh no /dccstor/fuse_med_ml/fuse-drug/cicd/envs/ | |||
There was a problem hiding this comment.
I don't see why we need to enforce it and use conda installation.
SagiPolaczek
commented
Sep 1, 2024
fusedrug_examples/requirements.txt
Outdated
| dscript | ||
| dgl | ||
| pysmiles | ||
| deepchem | ||
| mol2vec @ git+https://github.com/samoturk/mol2vec | ||
| paccmann_predictor @ git+https://[email protected]/PaccMann/paccmann_predictor#egg=paccmann-predictor | ||
| modlamp | ||
| torchtext==0.3.1 # old version of tokenizer - need to replace with another tokenizer and remove this |
There was a problem hiding this comment.
The last version is 0.18 (!) , plus they stopped the development of it.
added 2 commits
September 1, 2024 21:23
SagiPolaczek
changed the base branch from
main
to
modular_tokenizer_refactor
|
Closing - modifications merged to #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLMDTITestCase) that uses an external git submodule. The issue arises with 'dgl' lib: