Enable 'makeTxDbFromEnsembl()' to fill up genome version #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by this issue opened in the gDNAx package, and related to this other issue about adding genome version information to
TxDb
objects, this PR enablesmakeTxDbFromEnsembl()
to fill up the genome version information available in the Ensembl database. Currently, this does not happen:and AFAICS there is no workaround, because the function
makeTxDbFromEnsembl()
does not take ametadata
argument as inmakeTxDbFromGFF()
. This PR allowsmakeTxDbFromEnsembl()
to fill up the genome version:The implementation adds the column
coord_system_version
from theseq_region
table in the Ensembl database to a column calledgenome
in the internalchrominfo
data.frame
object. This is passed to themakeTxDb()
function, which uses that column to add that genome information as metadata when creating theTxDb
object.