Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop and type to generic signature of [row|col]Quantiles #14

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

const-ae
Copy link
Collaborator

After some discussion with @LTLA in const-ae/sparseMatrixStats#7, I decided that it is probably a good idea to include drop and type (which sparseMatrixStats now fully supports) in the generic method signature.

What do you think?

@hpages
Copy link
Contributor

hpages commented Sep 29, 2020

Well, as a general rule, if matrixStats::rowQuantiles has the arguments, the generic should probably have them too.

@hpages
Copy link
Contributor

hpages commented Sep 29, 2020

I'm talking about arguments that make sense for matrix-like objects in general. Not all arguments fall in that category but it seems that drop and type do.

@PeteHaitch
Copy link
Collaborator

Where do we sit on this?

@const-ae const-ae force-pushed the arguments_in_generic branch from ea6ee5f to 298079e Compare October 15, 2020 08:18
@const-ae
Copy link
Collaborator Author

I rebased the PR on the current master to resolve the merge conflict. I think we can merge this now :)

@PeteHaitch PeteHaitch merged commit 1b16d26 into Bioconductor:master Oct 19, 2020
@PeteHaitch
Copy link
Collaborator

Thanks, @const-ae!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants