Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs #9

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix some bugs #9

merged 2 commits into from
Dec 13, 2024

Conversation

jakobnissen
Copy link
Member

  • Make sure == doesn't dispatch to memcmp if the mem's eltype is a union, since in that case the array's bits can be the same but its content differ due to the type metadata array. Also, test for this
  • However, ensure that =='ing immutable and mutable arrays does dispatch to memchr, even if the two arrays type differ in mutability
  • Fix an edge case in split_unaligned when no part of the array is aligned
  • Minor refactor, using the internal truncate functions more. This change allows some branches to be omitted.

* Make sure == doesn't dispatch to memcmp if the mem's eltype is a union, since
  in that case the array's bits can be the same but its content differ due to
  the type metadata array. Also, test for this
* However, ensure that =='ing immutable and mutable arrays does dispatch to
  memchr, even if the two arrays type differ in mutability
* Fix an edge case in split_unaligned when no part of the array is aligned
* Minor refactor, using the internal truncate functions more. This change allows
  some branches to be omitted.
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.55%. Comparing base (83b4218) to head (d7bc579).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/basic.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   98.34%   97.55%   -0.80%     
==========================================
  Files           5        5              
  Lines         242      245       +3     
==========================================
+ Hits          238      239       +1     
- Misses          4        6       +2     
Flag Coverage Δ
unittests 97.55% <88.23%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakobnissen jakobnissen merged commit febf66c into master Dec 13, 2024
11 checks passed
@jakobnissen jakobnissen deleted the bugfix branch December 13, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant