Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ad_save_images_dir #689

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

bluelovers
Copy link
Contributor

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 18, 2024
@Bing-su
Copy link
Owner

Bing-su commented Aug 19, 2024

First of all, could you please include an explanation for why this is needed? I can't agree with the need for this option.

@bluelovers
Copy link
Contributor Author

the current ad image is saved as the same as the image directory
this means we can't easily split and browser images with ad images and images generated

also, some other extensions like controlnet are save detect_map in other directories too

we should not put all these files into one folder because it will be very hard to find them

split it into different folders is better
image

@bluelovers bluelovers changed the title feat: add ad-save-images feat: add ad_save_images_dir Aug 20, 2024
@Bing-su
Copy link
Owner

Bing-su commented Aug 21, 2024

Isn't that a subjective opinion?
I like this structure with the final and intermediate images together.

@bluelovers
Copy link
Contributor Author

Isn't that a subjective opinion? I like this structure with the final and intermediate images together.

ok, now it only enables when not empty

Copy link

@Bing-su Bing-su merged commit cc0a113 into Bing-su:dev Aug 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants