Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to add multiple extra models dirs separated by colons #596

Merged
merged 4 commits into from
May 6, 2024

Conversation

Natans8
Copy link
Contributor

@Natans8 Natans8 commented Apr 27, 2024

Useful for people who store models both locally and remotely, this is the simplest implementation I could think off.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 27, 2024
@Bing-su
Copy link
Owner

Bing-su commented Apr 27, 2024

Thanks for your contribution!

In Windows, colon is used as a drive symbol (eg. C:\stable-diffusion-webui), so you need to use a different separator. It would be nice if you change the example to be Windows friendly as well.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Natans8
Copy link
Contributor Author

Natans8 commented Apr 27, 2024

Thanks for your contribution!

In Windows, colon is used as a drive symbol (eg. C:\stable-diffusion-webui), so you need to use a different separator. It would be nice if you change the example to be Windows friendly as well.

Thank you for the quick response!
I changed the delimiter to |, which is a reserved character on windows, so now it should work on both. UNIX doesn't really have any reserved characters other than \ and NULL but this one should be really uncommon in most cases.

The more elegant long-term solution would be to convert the Textbox component a Gradio Dataset component or something similar, but the transition from previous versions wouldn't be as smooth, and I'm not experienced enough in Gradio to deal with that.

@Bing-su Bing-su merged commit dc451ca into Bing-su:dev May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants