feat: change script to support more than 1 git repository gf-589 #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemZag
requested review from
what1s1ove,
liza-veis and
yevhenii-hladkov
as code owners
ArtemZag
force-pushed
the
589-feat-script-should-support-more-than-1-local-git-repository
branch
4 times, most recently
from
845146e to
a5a77a2
Compare
ArtemZag
force-pushed
the
589-feat-script-should-support-more-than-1-local-git-repository
branch
2 times, most recently
from
8e80d83 to
5ec5526
Compare
ArtemZag
changed the title
ArtemZag
force-pushed
the
589-feat-script-should-support-more-than-1-local-git-repository
branch
from
5ec5526 to
c66eb9b
Compare
ArtemZag
changed the title
ArtemZag
force-pushed
the
589-feat-script-should-support-more-than-1-local-git-repository
branch
2 times, most recently
from
c6567b6 to
aff30fd
Compare
liza-veis
reviewed
Oct 2, 2024
| @@ -116,4 +122,50 @@ class AnalyticsService { | |||
| } | |||
| } | |||
|
|
|||
| function mergeStats( | |||
There was a problem hiding this comment.
We keep all helpers separately in a separate folder in libs/helpers, for example
/scripts/analytics/src/modules/analytics/libs/helpers/merge-stats/merge-stats.helper.ts
/scripts/analytics/src/modules/analytics/libs/helpers/merge-by-criteria/merge-by-criteria.helper.ts
And then they should be re-exported from /scripts/analytics/src/modules/analytics/libs/helpers/helper.ts
Take a look at this structure here /apps/backend/src/libs/plugins/authorization/
There was a problem hiding this comment.
Also, we use arrow functions instead of function declaration, except for migrations because it's generated by default
ArtemZag
force-pushed
the
589-feat-script-should-support-more-than-1-local-git-repository
branch
5 times, most recently
from
c6dacc7 to
2e5d7d6
Compare
liza-veis
approved these changes
Oct 3, 2024
yevhenii-hladkov
approved these changes
Oct 3, 2024
…589) - moved helpers into src/libs/helpers - changed functions to arrow functions
ArtemZag
force-pushed
the
589-feat-script-should-support-more-than-1-local-git-repository
branch
from
2e5d7d6 to
2649618
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.