Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v1.17.10 (Protocol 448) #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support v1.17.10 (Protocol 448) #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shoghicp/BigBrother/BigBrother.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function onEnable(){
}

if($enable){
if(Info::CURRENT_PROTOCOL === 422){
if(Info::CURRENT_PROTOCOL === 448){
ConvertUtils::init();

$this->saveDefaultConfig();
Expand Down
1 change: 1 addition & 0 deletions src/shoghicp/BigBrother/DesktopPlayer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ public function bigBrother_authenticate(string $uuid, ?array $onlineModeData = n
}

$skin = new SkinImage($skinImage);
$pk->clientData["PlayFabId"] = "";
$pk->clientData["SkinData"] = $skin->getSkinImageData(true);
$skinSize = $this->getSkinImageSize(strlen($skin->getRawSkinImageData(true)));
$pk->clientData["SkinImageHeight"] = $skinSize[0];
Expand Down
6 changes: 5 additions & 1 deletion src/shoghicp/BigBrother/network/Packet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
namespace shoghicp\BigBrother\network;

use pocketmine\item\Item;
use pocketmine\network\mcpe\protocol\types\inventory\ItemStackWrapper;
use shoghicp\BigBrother\utils\Binary;
use shoghicp\BigBrother\utils\ConvertUtils;
use shoghicp\BigBrother\utils\ComputerItem;
Expand Down Expand Up @@ -103,7 +104,10 @@ protected function getSlot() : Item{
}
}

protected function putSlot(Item $item) : void{
protected function putSlot($item) : void{
if($item instanceof ItemStackWrapper) {
$item = $item->getItemStack();
}
ConvertUtils::convertItemData(true, $item);

if($item->getID() === 0){
Expand Down
Loading