[WIP] Rewrite version of phar plugin package #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalharvest
changed the title
eternalharvest
force-pushed
the
feature/phar_rewrite_version
branch
from
1f24748 to
c6e8d5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We have currently no stable release, so plugin is released under as is basis.
But the current version number representation has no meaning because it is always same '1.6.0-beta'.
And it is not convenient for debubuging / bug report.
So I wrote a PR for rewriting version number with git revision when building plugin in phar format.
Behavioural changes
Nothing.
Follow-up