Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for version 2.2.3 #70

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Update documentation for version 2.2.3 #70

merged 5 commits into from
Oct 29, 2024

Conversation

mathew-thomson
Copy link
Collaborator

Update documentation for version 2.2.3 - changed the dictionary and version

@mathew-thomson
Copy link
Collaborator Author

@yulric - when you get the chance can you review this and let me know where I'm messing up? Thank you!

@yulric
Copy link
Collaborator

yulric commented Oct 17, 2024

The d in dictionary should be lower case i.e. it should be ODM_dictionary_2.2.3.xlsx not ODM_Dictionary_2.2.3.xlsx. Let me know if you want me to change the code so that the dictionary file name is case insensisitve.

@mathew-thomson
Copy link
Collaborator Author

@yulric tried the name change fix but it still failed... Sorry for the trouble

@yulric
Copy link
Collaborator

yulric commented Oct 28, 2024

@mathew-thomson Looks like the rename did not work. After googling it looks like on Macs Git does not pick up file renames if they just change the case, you have to use the git mv command in the terminal. I've fixed it now though so the build is working.

@mathew-thomson
Copy link
Collaborator Author

Thank @yulric - I noticed that when I made the file name change it didn't register as a merge change. So I tried to make some other small changes to maybe trigger the difference, but to no avail, sorry. Thank for making the changes, and sorry for the trouble!

@mathew-thomson mathew-thomson merged commit 6e2316e into main Oct 29, 2024
1 check passed
@mathew-thomson mathew-thomson deleted the 2.2.3-update branch October 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants