Cmake modernizations, update .clangformat #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiagioFesta
reviewed
May 3, 2023
| * Here you can set the size of the population and the random seed used internally. | ||
| * \note `populationSize` must be greater than zero, otherwise Undefined Behavior. | ||
| * Here you can set the size of the population and the random seed used | ||
| * internally. \note `populationSize` must be greater than zero, otherwise |
There was a problem hiding this comment.
are we able to keep indentation for doxygen comments?
- Indentation should be aligned with the first line
\commandshould be prefixed by newline
| */ | ||
| void initialize(const std::size_t populationSize, const SeedT rndSeed = DefaultSeed); | ||
| void initialize(const std::size_t populationSize, |
| @@ -104,8 +113,9 @@ class EvolutionNet { | |||
| }; | |||
|
|
|||
| template <int NumInput, int NumOutput, bool Bias, typename ParamConfig> | |||
| void EvolutionNet<NumInput, NumOutput, Bias, ParamConfig>::initialize(const std::size_t populationSize, | |||
| const SeedT rndSeed) { | |||
| void EvolutionNet<NumInput, NumOutput, Bias, ParamConfig>::initialize( | |||
There was a problem hiding this comment.
I would prefer having first argument on the same line. we can adjust the clang format I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: