Volume Update Merge #576
Merged
Volume Update Merge #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… finalized multiple routes handling.
Hotfix hybrid cloud
… work to spot key issues earlier
… work to spot key issues earlier
* renamed volumeSize to bootVolumeSize to avoid name issues * added implementation for adding volumes to permanent workers (they are not deleted) * implemented creating and terminating volumes without filesystem for permanent workers * fully working for permanent workers. masterMount is broken now, but also replaced. Will be fixed. * Added volume creation to create_server. Not yet working. * hostvar for each host * Fixed information handling and naming issues * fixed host yaml creation * removed unnecessary prints * improved readability fixed minor bugs * added volume deletion and set volume_ap_version explicitly * removed prints from test_provider.py * improved readability greatly. Fixed overwriting host vars bug * snapshot and existing volumes can now be attached to master and workers on startup * snapshot and existing volumes can now be attached to master and workers on startup * removed mountPoint from a log message in case no mount point is specified * fixed lsblk not finding item.device due to race condition * improved comments and naming * removed server automount. This is now handled by a single automount task for both master and workers * allows nor to start new permanent volumes if a name is given. One could consider adding tmp to not named volumes for additional clarity * fixed wrong function call * renamed nfs_mount to nfs_shares * added semipermanent as an option * fixed wrong method of default values for Ansible * started reworking * added volumes and changed bootVolumes * updated bibigrid.yaml and aligned naming of bootVolume and volume * added newline at end of file * removed superfluous provider paramter * pleased linting * removed argument from function call * moved host vars creation, vars deletion, added comments * largely reworked how volumes are attached to servers to be more explicit * small naming fixes * updated priority order of permanent and semiPermanent. Updated documentation to new explicit bool setup. Added type as a key. * fixed bug regarding dontUploadCredentials * updated schema validation * Update linting.yml * Update linting.yml * Update linting.yml * Update linting.yml * added __init__.py where appropriate * update bibigrid.yaml for more explicit volumes documentation * volumes are now validated and fixed old state of masterInstance in validate_schema.py * Update linting.yml * Update linting.yml * fixed longtime naming bug for unknown openstack exceptions * saves more info in .mem file * moved structure of tests and added a basic integration_test file that needs to be expanded and improved * moved tests * added "not ready yet" * updated bootVolume documentation * moved tests added __init__.py files for better discovery. minor fixes * updated tests and comments * updated tests and comments * updated tests, code and comments for ansible_configuration * updated tests for ansible_configurator * fixed test_ansible_configurator.py * fixed test_configuration_handler.py * improved exception messages * pleased ansible linter * fixed terminate return values test * improved naming * added tests to make sure that server regex only deletes bibigrid servers with fitting cluster id and same for volumes * pleased pylint * fixed validation issue when using exists in master * removed forgotten print * fixed description bug * final bugfixes * pleased linter * fixed too many positional arguments
jkrue
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates
masterMountsfor instance specificvolumeswhich is much more powerful. Documentation can be found in the configuration documentation.