Skip to content

Commit

Permalink
converted implicit to explicit octet notation
Browse files Browse the repository at this point in the history
  • Loading branch information
XaverStiensmeier committed Sep 13, 2024
1 parent 882f8d6 commit 2dc9529
Show file tree
Hide file tree
Showing 13 changed files with 43 additions and 43 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
dest: "{{ item.path }}.disabled"
owner: root
group: root
mode: 0644
mode: 0o644

Check failure on line 18 in resources/playbook/roles/bibigrid/tasks/000-add-ip-routes.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o644"
remote_src: true
with_items: "{{ collected_files.files }}"
- name: Remove collected files
Expand All @@ -30,7 +30,7 @@
line: "network: {config: disabled}"
owner: root
group: root
mode: 0644
mode: 0o644

Check failure on line 33 in resources/playbook/roles/bibigrid/tasks/000-add-ip-routes.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o644"
create: true

- name: Generate location specific worker userdata
Expand All @@ -39,7 +39,7 @@
dest: "/etc/systemd/network/bibigrid_ens3.network"
owner: root
group: systemd-network
mode: 0640
mode: 0o640

Check failure on line 42 in resources/playbook/roles/bibigrid/tasks/000-add-ip-routes.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o640"
become: true
notify:
- systemd-networkd restart
Expand All @@ -50,7 +50,7 @@
dest: "/etc/systemd/network/bibigrid_ens3.link"
owner: root
group: systemd-network
mode: 0640
mode: 0o640

Check failure on line 53 in resources/playbook/roles/bibigrid/tasks/000-add-ip-routes.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o640"
become: true
notify:
- systemd-networkd restart
2 changes: 1 addition & 1 deletion resources/playbook/roles/bibigrid/tasks/001-apt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
dest: /etc/apt/apt.conf.d/20auto-upgrades
owner: root
group: root
mode: 0644
mode: 0o644

Check failure on line 11 in resources/playbook/roles/bibigrid/tasks/001-apt.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o644"

- name: Wait for cloud-init / user-data to finish
command: cloud-init status --wait
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
dest: /etc/systemd/network/wg0.netdev
owner: root
group: systemd-network
mode: 0640
mode: 0o640

Check failure on line 12 in resources/playbook/roles/bibigrid/tasks/002-wireguard-vpn.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o640"
become: true
notify:
- systemd-networkd restart
Expand All @@ -20,7 +20,7 @@
dest: /etc/systemd/network/wg0.network
owner: root
group: systemd-network
mode: 0640
mode: 0o640

Check failure on line 23 in resources/playbook/roles/bibigrid/tasks/002-wireguard-vpn.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o640"
become: true
notify: systemd-networkd restart

Expand Down
4 changes: 2 additions & 2 deletions resources/playbook/roles/bibigrid/tasks/011-zabbix-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
file:
path: /etc/zabbix/zabbix_agentd.d/
state: directory
mode: 0755
mode: 0o755

Check failure on line 14 in resources/playbook/roles/bibigrid/tasks/011-zabbix-agent.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o755"

- name: Create zabbix_agent log directory
file:
path: /var/log/zabbix
state: directory
owner: zabbix
group: zabbix
mode: 0755
mode: 0o755

Check failure on line 22 in resources/playbook/roles/bibigrid/tasks/011-zabbix-agent.yaml

View workflow job for this annotation

GitHub Actions / linting-job

yaml[octal-values]

Forbidden explicit octal value "0o755"

- name: Adjust zabbix agent configuration
template:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
template:
src: zabbix/zabbix_server.conf.j2
dest: /etc/zabbix/zabbix_server.conf
mode: 0644
mode: 0o644
notify: zabbix-server

- name: Start and Enable zabbix-server
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
file:
path: "/vol/{{ item.mount_point }}"
state: directory
mode: '0755'
mode: 0o755
owner: root
group: '{{ ansible_distribution | lower }}'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
file:
path: /vol/scratch
state: directory
mode: 0777
mode: 0o777
8 changes: 4 additions & 4 deletions resources/playbook/roles/bibigrid/tasks/020-disk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,29 @@
state: directory
owner: root
group: '{{ ansible_distribution | lower }}'
mode: 0775
mode: 0o775

- name: Create /vol/ directory with rights 0775 owned by root
file:
path: /vol/
state: directory
owner: root
group: '{{ ansible_distribution | lower }}'
mode: 0775
mode: 0o775

- name: Create /vol/spool/ directory with rights 0777
file:
path: /vol/spool/
state: directory
mode: 0777
mode: 0o777

- name: Change rights of /opt directory to 0775 and set group to ansible_distribution
file:
path: /opt
state: directory
owner: root
group: '{{ ansible_distribution | lower }}'
mode: 0775
mode: 0o775

- name: Create link in '{{ ansible_distribution | lower }}' home
file:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
state: directory
owner: root
group: root
mode: 0777
mode: 0o777
with_items:
- "{{ nfs_mounts }}"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
state: directory
owner: root
group: root
mode: 0777
mode: 0o777
with_items:
- "{{ nfs_mounts }}"

Expand Down
2 changes: 1 addition & 1 deletion resources/playbook/roles/bibigrid/tasks/030-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
dest: /etc/docker/daemon.json
owner: root
group: root
mode: 0644
mode: 0o644
notify:
docker

Expand Down
32 changes: 16 additions & 16 deletions resources/playbook/roles/bibigrid/tasks/042-slurm-server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
file:
path: /etc/openstack/clouds.yaml
group: slurm
mode: '0640' # (owner can read/write, group can read, others have no access)
mode: 0o640 # (owner can read/write, group can read, others have no access)

- name: Create slurm db
mysql_db:
Expand All @@ -24,7 +24,7 @@
dest: /etc/slurm/slurmdbd.conf
owner: slurm
group: root
mode: "0600"
mode: 0o600

- name: Generate random JWT Secret
command:
Expand All @@ -36,22 +36,22 @@
path: /etc/slurm/jwt-secret.key
owner: slurm
group: slurm
mode: "0600"
mode: 0o600

- name: Copy env file for configuration of slurmrestd
copy:
src: slurm/default/slurmrestd
dest: /etc/default/slurmrestd
owner: root
group: root
mode: "0644"
mode: 0o644

- name: Create system overrides directories (slurmdbdm slurmrestd)
file:
path: "/etc/systemd/system/{{ item }}.service.d"
group: root
owner: root
mode: "0755"
mode: 0o755
state: directory
with_items:
- slurmdbd
Expand All @@ -61,7 +61,7 @@
copy:
src: "slurm/systemd/{{ item }}.override"
dest: "/etc/systemd/system/{{ item }}.service.d/override.conf"
mode: "0644"
mode: 0o644
owner: root
group: root
with_items:
Expand All @@ -81,69 +81,69 @@
group: ansible
path: /opt/slurm/
state: directory
mode: "0770"
mode: 0o770

- name: Ensures /etc/slurm dir exists
file:
path: /etc/slurm/
state: directory
mode: 0755
mode: 0o755

- name: Ensures /opt/slurm/.ssh/ dir exists
file:
path: /opt/slurm/.ssh/
group: slurm
owner: slurm
state: directory
mode: 0700
mode: 0o700

- name: Copy private key (openstack keypair)
copy:
src: ~/.ssh/id_ecdsa
dest: /opt/slurm/.ssh/id_ecdsa
owner: slurm
group: slurm
mode: "0600"
mode: 0o600

- name: Copy create program script (power)
copy:
src: slurm/create.sh
dest: /opt/slurm/create.sh
owner: slurm
group: ansible
mode: "0550"
mode: 0o550

- name: Copy terminate program script (power)
copy:
src: slurm/terminate.sh
dest: /opt/slurm/terminate.sh
owner: slurm
group: ansible
mode: "0550"
mode: 0o550

- name: Copy fail program script (power)
copy:
src: slurm/fail.sh
dest: /opt/slurm/fail.sh
owner: slurm
group: ansible
mode: "0550"
mode: 0o550

- name: Copy "create_server.py" script
copy:
src: slurm/create_server.py
dest: /usr/local/bin/create_server.py
owner: slurm
group: ansible
mode: "0750"
mode: 0o750

- name: Copy "delete_server.py" script
copy:
src: slurm/delete_server.py
dest: /usr/local/bin/delete_server.py
owner: slurm
group: ansible
mode: "0750"
mode: 0o750

- name: Install python dependencies
pip:
Expand All @@ -169,7 +169,7 @@
dest: "/opt/slurm/userdata_{{ hostvars[item].cloud_identifier }}.txt"
owner: slurm
group: ansible
mode: "0640"
mode: 0o640
with_items: "{{ groups.vpngtw + groups.master }}"

- name: Enable slurmdbd and slurmrestd services
Expand Down
16 changes: 8 additions & 8 deletions resources/playbook/roles/bibigrid/tasks/042-slurm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
Pin: version 23.11.*
Pin-Priority: 1001
dest: /etc/apt/preferences.d/slurm-bibigrid
mode: '0311'
mode: 0o311

- name: Install slurm-bibigrid package
apt:
Expand All @@ -34,15 +34,15 @@
dest: /etc/munge/munge.key
owner: munge
group: munge
mode: 0600
mode: 0o600
notify:
- munge

- name: Ensures slurm directories exists
file:
path: "{{ item }}"
state: directory
mode: 0775
mode: 0o775
owner: root
group: slurm
with_items:
Expand All @@ -55,7 +55,7 @@
path: "/etc/systemd/system/{{ item }}.service.d"
group: root
owner: root
mode: "0755"
mode: 0o755
state: directory
with_items:
- slurmd
Expand All @@ -65,7 +65,7 @@
copy:
src: "slurm/systemd/{{ item }}.override"
dest: "/etc/systemd/system/{{ item }}.service.d/override.conf"
mode: "0644"
mode: 0o644
owner: root
group: root
with_items:
Expand All @@ -89,23 +89,23 @@
dest: /etc/slurm/slurm.conf
owner: slurm
group: root
mode: 0444
mode: 0o444

- name: Create Job Container configuration
template:
src: slurm/job_container.j2
dest: /etc/slurm/job_container.conf
owner: slurm
group: root
mode: 0444
mode: 0o444

- name: Slurm cgroup configuration
copy:
src: slurm/cgroup.conf
dest: /etc/slurm/cgroup.conf
owner: slurm
group: root
mode: 0444
mode: 0o444

- name: Restart slurmd
systemd:
Expand Down

0 comments on commit 2dc9529

Please sign in to comment.