fix!: use textScaler instead of a double #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanlooverenkoen
requested review from
samandmoore,
Kirpal,
jeroen-meijer,
btrautmann,
jolexxa,
marcossevilla and
a team
as code owners
jeroen-meijer
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
LGTM
@btrautmann I'll leave final review up to you, but I think there's no harm in supporting this.
It is technically a (partially) breaking change though, so not sure what to do versioning-wise.
btrautmann
approved these changes
Oct 3, 2024
Yeah, I'll version it accordingly (minor bump since we're still pre-1.0.0) |
|
Thanks @vanlooverenkoen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Give people more control over the textScaleFactor with an actual textScaler instead of the textScaleFactor double
Type of Change