ci: channel compatibility workflow #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btrautmann
requested review from
samandmoore,
Kirpal,
jeroen-meijer and
marcossevilla
as code owners
This was referenced Sep 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 562 555 -7
=========================================
- Hits 562 555 -7 ☔ View full report in Codecov by Sentry. |
7 tasks
btrautmann
force-pushed
the
bt/compat-job
branch
from
0e20a95 to
987cc6e
Compare
… into bt/compat-job
… into bt/compat-job
Kirpal
previously approved these changes
Sep 18, 2024
samandmoore
reviewed
Sep 18, 2024
| @@ -263,11 +263,8 @@ class FlutterGoldenTestAdapter extends GoldenTestAdapter { | |||
| maxWidth: constraints.maxWidth, | |||
| maxHeight: constraints.maxHeight, | |||
| child: Center( | |||
| child: Padding( | |||
There was a problem hiding this comment.
@btrautmann what is the reasoning behind this removal of the Padding?
There was a problem hiding this comment.
See #105
I didn't think it would make sense to maintain a configuration option so I removed the padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a workflow that will eventually run daily to check alchemist's compatibility with the current latest
stableandbetaversions of the framework.Note: I'm not enabling the CRON schedule right now because there are actually a couple failing tests on stable and beta channels. It looks like there were some more color changes introduced at some point that cause large pixel diffs. I'm going to try and tackle #120 and then enable this.The idea of this workflow is to get advanced notice of changes that would "break" consumers of alchemist (for a number of reasons). One recent example is that in upgrading our min version constraint to 3.16.0 we ran against the fact that this was the first major version of Flutter that enabled material 3 by default. Changes trickled down through Alchemist and caused golden failures for consumers, even when they had disabled material 3 in their projects. We should aim to be material agnostic and, all else equal, test golden images generated by alchemist should be compatible with master golden images generated on different versions of the framework. This may not be possible in all cases, but this workflow will at least give us advanced notice so we can decide what is alchemist's fault and what is Flutter's fault.
When we encounter a failure, those in the
#mobile-oss-coordinationchannel will see a message similar to this:Closes #119.
Fixes #105.
Type of Change
BREAKING CHANGE: This technically introduces a breaking change in that it removes a couple
Paddings to reduce Alchemist's impact on the resulting goldens.