Disable notebook support for normal clojure file extensions #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svdo
force-pushed
the
change-notebook-extensions
branch
5 times, most recently
from
d05d53c
to
19aadb1
Compare
svdo
force-pushed
the
change-notebook-extensions
branch
2 times, most recently
from
500685f
to
58ed08c
Compare
svdo
force-pushed
the
change-notebook-extensions
branch
from
58ed08c
to
0b01458
Compare
svdo
force-pushed
the
change-notebook-extensions
branch
from
0b01458
to
8d0e341
Compare
svdo
force-pushed
the
change-notebook-extensions
branch
from
8d0e341
to
9411b73
Compare
svdo
force-pushed
the
change-notebook-extensions
branch
from
9411b73
to
adb178d
Compare
svdo
force-pushed
the
change-notebook-extensions
branch
2 times, most recently
from
8c6caab
to
d6eb9e9
Compare
This is a work-around because currently Live Share causes clojure files to always be opened as notebooks. See: BetterThanTomorrow#1850
svdo
force-pushed
the
change-notebook-extensions
branch
from
d6eb9e9
to
9d7f713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-around because currently Live Share causes clojure files to always be opened as notebooks.
See:
#1850
This PR is not intended actually be merged. It is a method (proposed by @PEZ) to use custom Calva builds without notebook support, so that we're not stuck on an older version of Calva. Hopefully the dynamic notebook APIs will be added to VSCode soon, so that we don't have to configure it in
package.jsonanymore and this PR can be deleted.This PR is automatically built by CircleCI. You can click "show all checks", click on the link to "ci/circleci: build", go to the artefacts tab, and grab the built
vsixthere, and manually install it.