Remove duplicate uniqueness validation on users #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A uniqueness validation for the user `email` attribute has already been added by the `Clearance::User::Validations` module in [clearance/user.rb#L144-L148](https://github.com/thoughtbot/clearance/bl ob/3e9529a643cff20beb9bb49eacedb90dee49d465/lib/clearance/user.rb#L144-L 148). Duplicating the validation rule was resulting in duplicate error responses from the API. In addition, there is no need to specify a `case_sensitive` property for the uniqueness validation on _non-text_ columns (the email column type is `varchar`), as it is ignored. This update removes the redundant uniqueness validation for `user#email`, therefore preventing multiple email validation errors that were occurring in API responses. Closes Bernie-2016#108
|
@patrickcousins can I get a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A uniqueness validation for the user
emailattribute has already been added by theClearance::User::Validationsmodule in clearance/user.rb#L144-L148. Duplicating the validation rule was resulting in duplicate error responses from the API.In addition, there is no need to specify a
case_sensitiveproperty for the uniqueness validation on non-text columns (the email column type isvarchar), as it is ignored.This update removes the redundant uniqueness validation for
user#email, therefore preventing multiple email validation errors that were occurring in API responses.Closes #108