Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user serializer without includes #111

Merged
merged 1 commit into from
Jan 9, 2016

Conversation

joshsmith
Copy link
Contributor

This solves the issue #110.

We could still use some specs to see that it's using the right serializer in the address controller.

@joshsmith
Copy link
Contributor Author

The problem is that we were using a UserSerializer that has a bunch of includes.

I'm wary of this approach simply because it introduces a lot of duplication. But I don't know a better way.

@joshsmith
Copy link
Contributor Author

I replaced it with a UserSerializerWithoutIncludes.

joshsmith added a commit that referenced this pull request Jan 9, 2016
…includes

Add user serializer without includes
@joshsmith joshsmith merged commit ad42d2e into development Jan 9, 2016
@joshsmith joshsmith deleted the add-user-serializer-without-includes branch January 9, 2016 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant