Bump CIBuildWheel Version to 2.15.0

[Eric-Vin]

To address Issue #69

[mikedh]

Thanks for the PR! Can you bump version.py too for the release process?

[Eric-Vin]

Done! I went with the most minor version increment but let me know if you'd like something else.

[mikedh]

Thanks for the fixes!! Sorry I'd fix these locally but I don't have the project open. I think to fix the build we need to:

• In pyproject.toml change Cython -> Cython<3 from how to compile python-fcl wheel from source? #67
• locally run pip install --upgrade black and run the latest version of black on the tests (and/or pin the version of black in the github actions YAML).

[Eric-Vin]

No problem at all, thank you for your help! I cloned the repo and made the changes you requested, and it looks like the wheels build with pip wheel ./ --no-deps -w wheelhouse/, at least on Linux.

[Eric-Vin]

Hmm, looks like black is still failing, I'll see about fixing that.

[mikedh]

Looks close! It seems like everything except 3.12 is working, which appears to be surfacing a bug/deprecation in setuptools? Looks like it's this one: pypa/setuptools#3935

[Eric-Vin]

Ah yep, distutils is deprecated in 3.12 according to https://peps.python.org/pep-0632/. Unfortunately I'm not really sure how to fix this one.

[mikedh]

Yeah 🥲. I think we're blocked until numpy/numpy#23808 gets fixed?

[mikedh]

Oh actually this looks like it could plausibly work:
numpy/numpy#23808 (comment)

[build-system]
requires = [
  'numpy; python_version<"3.12.0rc1"',
  'numpy>=1.26.0b1; python_version>="3.12.0.rc1"',
  # ...
]

[Eric-Vin]

Seems to work in 3.12 now! Hopefully the actions pass. I made a slightly different version that kept oldest-supported-numpy for older versions, so as to avoid breaking anything, but I can definitely drop that if you'd like.

[mikedh]

Looks like it's building now, only failing on 3.12 tests 😆. Thanks for all the followup on this PR!

It's a little suspicious python-fcl currently only has numpy in the build-system (which I don't know if the install respects?) I suspect it might need the version-locked numpy in project.dependencies too:

[project]
name = "python-fcl"
dependencies = ["numpy ...version-info-here"]

[Eric-Vin]

Ah good point. With this change I can now install properly in 3.12, so hopefully it'll fix the problem.

[Eric-Vin]

Shoot now it looks like there's a mismatch....

[mikedh]

Oh I wonder if this version range needs something for Python 3.6, or to drop Python 3.6. FWIW I've had to drop 3.6 on other projects due to pyproject.toml support and it would probably be fine to do that here if necessary.

ERROR: Some build dependencies for file:///project conflict with the backend dependencies: numpy==1.13.3 is incompatible with numpy>=1.26.0b1; python_version >= "3.12".

[Eric-Vin]

Hmm I would think it would just work, since for older versions like 3.6 it should fall back to oldest-supported-numpy. I wonder if it'll work if I change oldest-supported-numpy back to numpy in setup.cfg, since that's what it was originally.

[mikedh]

Oh looking at the logs my theory on this is that we're double-specifying the build system in both setup.cfg and pyproject.toml:

• setup.cfg is used on Python 3.6, and specified in setup_requires
• pyproject.toml is used on Python 3.7+ and is specified in build

[Eric-Vin]

Hmm, so does that mean we would want something like this?

setup_requires =
    numpy
    Cython
install_requires =
    numpy; python_version<'3.12'
    numpy>=1.26.0b1; python_version>='3.12'
    Cython

Since if we take the numpy specification out of both blocks in setup.cfg we'd get back to an earlier version which also had a crash. I'll push the above so we can give it a try.

[mikedh]

Looks like you got it great work! Thanks for the follow ups, these CI changes are particularly rough haha. I think at some point this project should probably use ini2toml to move everything from setup.cfg to pyproject.toml and drop 3.6 which would probably make this build a lot more stable.

[Eric-Vin]

Great! Thanks for guiding me through the process and for maintaining the project!