Minor improvements from SonarCloud

BentoBoxWorld · Aug 12, 2024 · d18a496 · d18a496
1 parent fa439ed
commit d18a496
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/src/main/java/world/bentobox/skygrid/generators/SkyGridChunks.java b/src/main/java/world/bentobox/skygrid/generators/SkyGridChunks.java
@@ -116,13 +116,10 @@ private void setBlock(BlockProbability prob, int x, int y, int z, List<SkyGridBl
         }
         // Convert to deep
         if (y < 0) {
-            if (blockMat == Material.STONE) {
-                blockMat = Material.DEEPSLATE;
-
-            } else if (blockMat == Material.COBBLESTONE) {
-                blockMat = Material.COBBLED_DEEPSLATE;
-            } else {
-                blockMat = Enums.getIfPresent(Material.class, "DEEPSLATE_" + blockMat.name()).or(blockMat);
+            switch (blockMat) {
+            case STONE -> blockMat = Material.DEEPSLATE;
+            case COBBLESTONE -> blockMat = Material.COBBLED_DEEPSLATE;
+            default -> blockMat = Enums.getIfPresent(Material.class, "DEEPSLATE_" + blockMat.name()).or(blockMat);
             }
         }
 

diff --git a/src/test/java/world/bentobox/skygrid/SettingsTest.java b/src/test/java/world/bentobox/skygrid/SettingsTest.java
@@ -27,11 +27,8 @@ public class SettingsTest {
 
     private Settings s;
 
-    /**
-     * @throws java.lang.Exception
-     */
     @Before
-    public void setUp() throws Exception {
+    public void setUp() {
         s = new Settings();
     }