Switchable Dark Theme - Attempt 2 - Ongoing #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… waitUntilReady()
…initialisation of fd_set
throwing if the constructor fails.
… the ADS816x and starting the PRU
…nd Scope accordingly
…e on Bela or Xenomai (well ... except for rt_fprintf()...), using std::thread and a std::mutex to manipulate the static constructor and properties. It could still use use some clarity around thread starting/stopping
…it is idempotent. Fixed a couple uninitialised values. Thanks valgrind
…n up after ourselves
…r the ref count of neither will ever reach zero and destructors won't be called
…d of shared_ptr. See https://floating.io/2017/07/lambda-shared_ptr-memory-leak/ for reasoning. This was not an immediate issue, but worth avoiding future issues and it makes more sense to have the shared_ptr for _managing_ objects and the weak_ptr for _using_ them
…s members) are still valid
…e server thread as it may become stale by the time the callback is executed. Instead, use the same weak_ptr approach used elsewhere. Also, use the same procedure where possible for sending binary or string.
…tly from the same thread as the callback. This allows to avoid allocation and copy as the send can be executed immediately instead of postponed in a lambda.
…e thread has already exited. Should close BelaPlatform#722
…aking in case of file not found)
… to automatically probe the whole range if needed
thread. Send 'auto' to automatically discover new MIDI devices.
giuliomoro
force-pushed
the
dev
branch
7 times, most recently
from
6379d53 to
8502912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! :) Here's my second attempt at implementing a theme switching for Bela's IDE.
The approach here is to use SCSS
@mixinand a map, allowing to define a colour variables for each of the themes.The main logic and colour variable definitions are located in
IDE/frontend-dev/scss/base.scss.The idea is that we (only) move every specific element properties affected by the theme switching into a theme switching function (
themify), performing the colour switch only on the relevant properties.In each scss file containing elements which need to change colour, the relevant properties for the element is being moved at the top of the file inside of the themify function.
While this may not the cleanest of look, it allows 2 things:
There's still a bit of work to get this polished, but sharing now if people wants to start testing/using it before.
ps: You can discard the commit history before Feb 14, 2024. They shouldn't be in the commit history but not sure how to safely rewrite the history.