Color correction

[DrDuckedGoose]

About The Pull Request

Adds a level of color correction to station areas. It's not overly complex or probably true color correction, but it works for our purposes. This also includes mapping helpers, one of these can be placed in an area to change that entire area's correction.

Essentially it's a subtle color-shift to areas

Why It's Good For The Game

Emphasizes the visual atmosphere of a given area

Testing Photographs and Procedure

Screenshots&Videos

Changelog

🆑
add: Adds color correction to areas
/:cl:

[PowerfulBacon]

The transition effect needs to be extremely slow and the colours need to be very, very subtle to prevent this being too noticeable

[DrDuckedGoose]

This is probably fine for now

adressed

[PowerfulBacon]

The fade needs to be way longer, at least 30 seconds.
Only warm/dark colours should be used for colour fading. Purples and greens don't work with colour correction very well.

[DrDuckedGoose]

increased fade time & changed hydro & science to cold_ish

[PowerfulBacon]

Putting this on testmerge again

[Penwin0]

My code reviews were adressed, and I think it looks good in game

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Cartlord]

Will users have an option to disable this, as they do with ambient occlusion?

[DrDuckedGoose]

Will users have an option to disable this, as they do with ambient occlusion?

No, but if someone hates it that much, they can surely ask someone else(not me) to do that

[PowerfulBacon]

I would rather not bloat preference anymore with unnecessary options that players don't know the effect of.

[Cartlord]

Will users have an option to disable this, as they do with ambient occlusion?

No, but if someone hates it that much, they can surely ask someone else(not me) to do that

Why do you, the person adding the feature, expect someone else to add a remedy if you end up creating a problem?

I would rather not bloat preference anymore with unnecessary options that players don't know the effect of.

That sounds like it could be fixed by adding a description to the pref

[CydiaLamiales]

Will users have an option to disable this, as they do with ambient occlusion?

No, but if someone hates it that much, they can surely ask someone else(not me) to do that

Why do you, the person adding the feature, expect someone else to add a remedy if you end up creating a problem?

There is no problem. Only you hate that the game doesn't look like it's 2014.

[PowerfulBacon]

I still don't want to add too many settings. I don't want players to have the option to make their game look worse and if this looks worse than without it and is too obvious, I won't be merging it.

[Cartlord]

Will users have an option to disable this, as they do with ambient occlusion?

Game not being fullbright burns the eyes of the /vg/ player

What of it? I personally dislike color correction as a concept, and I think adding it is a bad idea because nothing in the game was made with it in mind - so either it makes things look noticeably worse since it's fucking up the palettes, or it's so inconsequential that it might as well not be there - but I'm just one guy, which is why I'd rather it be a preference.

I still don't want to add too many settings. I don't want players to have the option to make their game look worse and if this looks worse than without it and is too obvious, I won't be merging it.

By this logic, why do we have preferences for things like Point Sampling vs Bilinear Filtering vs Nearest Neighbor, or for ambient occlusion, or to enable and disable tint from glasses? If there's an objective best way for the game to look, why not remove those settings so people have to play the game in the way that (you think) looks best?

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[PowerfulBacon]

Point Sampling vs Bilinear Filtering vs Nearest Neighbor, or for ambient occlusion, or to enable and disable tint from glasses?

Ambient occlusion could genuinely be removed, tint from glasses just gets in the way so kind of needs to be turned off and while I would love to remove the setting to change scaling mode, different monitor resolutions look blurry on certain settings so you need to choose the one for you