Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling mistake #9176

Merged
merged 6 commits into from
Jun 6, 2023

Conversation

JixS4v
Copy link
Contributor

@JixS4v JixS4v commented Jun 5, 2023

About The Pull Request

fixes sulfuric acid being called "sulphuric acid" in code

Why It's Good For The Game

consistency + spelling mistakes bad

Changelog

🆑
fix: sulfuric acid is now properly spelled
/:cl:

@EvilDragonfiend
Copy link
Member

🔑 soul removed (joke)

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 5, 2023

if it's such a joke, force push this :trollface:

@EvilDragonfiend
Copy link
Member

I will lift my key if you edit the pr contents correctly like this:

  • title: makes sulphuric acid spelling incorrect
  • body: incorrect spelling for the word is necessary to harass britishes
  • cl: sulphuric acid spelling is now more wrong

@PowerfulBacon
Copy link
Member

Wait but isn't sulphuric correct?

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 5, 2023

british spelling vs american spelling, but for consistency's sake and given that the international chemistry association prefers the american version i changed them all to sulfuric

@Isy232
Copy link
Contributor

Isy232 commented Jun 5, 2023

Screw the americans, long live the commonwealth and the correct spelling!

They've already taken armour from us, they shall advance no further!

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 5, 2023

Do british people actually exist? I mean, they must be a meme, there is a not a single thing about them. And I mean it.

Let's go through the evidence: Where are they from? Not a single country in the world is named Britain. Some people say they come from England, and England is inside Britain, but if that was the case they would be British they would be Englanders. Also, heard some silly theories about them coming from whales. Guys, no, whale people do not exist. Whales live in the sea.

There is a consensus on British people coming from Europe, but then we are left with a whole continent of possible locations. That's as good as nothing. What do they eat? Every country has at least one main dish. Even the US has their burgers. But these British people, what do they eat? Heard some people associating them with tea, but everyone knows that's an Asian thing. Shouldn't they come from Europe? One of these two points must be wrong them. To me, it looks too sketchy.

What language do they speak? I challenge you, putting all my money and my ass on the line here, to find a supposed ""British"" person speaking their native language. Most of then just speak a broken ENGLISH. Yes, english. Really suspicious, huh? And I even tried to look deeper into it. Maybe british just SOUND like english, just like spanish could sound like portuguese for a non-speaker. So I looked up "british dictionary on google" and what I found was shocking: every word in there was AMERICAN. I kid you not. What this could mean is beyond my capabilities, but I can safely assure you that british people do not exist .

@Rustyfoxb
Copy link

If most things in game are written in british english then would it be a misspelling to make it american english for the word?, Just asking since i haven't checked all the spelling in the code

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 5, 2023

image

i'm seeing other stuff in american english

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 5, 2023

alright maints, time to forcepush it

@Tsar-Salat
Copy link
Contributor

#8492 I got denied for changing a word between American and British English, this guy should suffer too!

Deny deny deny!

@JixS4v
Copy link
Contributor Author

JixS4v commented Jun 5, 2023

i'm literally doing the opposite lol, repo ban this guy :trollface:

@PowerfulBacon
Copy link
Member

The chemistry authority spells it wrong, so I approve of this PR

@Tsar-Salat
Copy link
Contributor

Gentlemen.

I have found the compromise.

Screenshot_20230605_154909

Copy link
Member

@itsmeow itsmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sulfuric is the correct IUPAC spelling and what is used in Fluorosulfuric acid. These two should at minimum be consistent with each other since they're the same words.

@itsmeow
Copy link
Member

itsmeow commented Jun 6, 2023

#8492 I got denied for changing a word between American and British English, this guy should suffer too!

Deny deny deny!

You didn't get denied, you just closed the PR without finishing it :3

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Jun 6, 2023
Merged via the queue into BeeStation:master with commit fe5ce2d Jun 6, 2023
EvilDragonfiend pushed a commit to EvilDragonfiend/BeeStation-Hornet-Evildragon-Fork that referenced this pull request Jun 8, 2023
* server config

* Revert "server config"

This reverts commit f7c59fc.

* minor spelling mistake, argument destroyed
EvilDragonfiend pushed a commit to EvilDragonfiend/BeeStation-Hornet-Evildragon-Fork that referenced this pull request Jun 8, 2023
@JixS4v JixS4v deleted the minor-spelling-mistake branch December 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants