Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated headwear (from hooded and hard suits) are now Fireproofed by the Fireproof chaplain spell #10089

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

HowToLoLu
Copy link
Contributor

@HowToLoLu HowToLoLu commented Oct 24, 2023

About The Pull Request

When hoods were changed to be stored in nullspace with #9686, apparently there was still one thing that relies on the clothing's contents. That thing was apparently the fireproofing ritual of the candle religious sect.

Update: Decided to add hardsuit support

Why It's Good For The Game

Something that just makes sense because the helmet/hood is inseparable from the suit.

Testing Photographs and Procedure

Screenshots&Videos

Hooded

image

image


Hardsuit

image

image

Changelog

🆑
fix: The chaplain Fireproof ritual now fireproofs hoods in hooded clothing again.
add: Integrated hardsuit helmets now can be fireproofed in the fireproof ritual.
/:cl:

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not only exclusive to hoods. Every item that has suit-attached hat has the issue.
and... I checked the code, and it looks only hardsuit has the issue.

@HowToLoLu
Copy link
Contributor Author

I think it's not only exclusive to hoods. Every item that has suit-attached hat has the issue.
and... I checked the code, and it looks only hardsuit has the issue.

Wasn't sure if I should add hardsuits to it- I'll do that now then, thanks.

@HowToLoLu HowToLoLu changed the title Fix: Hoods weren't being fireproofed in chaplain ritual Integrated headwear (from hooded and hard suits) are now Fireproofed by the Fireproof chaplain spell Oct 27, 2023
@EvilDragonfiend EvilDragonfiend added this pull request to the merge queue Oct 27, 2023
Merged via the queue into BeeStation:master with commit a997ab6 Oct 27, 2023
8 checks passed
@HowToLoLu HowToLoLu deleted the fix-hooded branch November 27, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants