Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignore] feat(files): All Aesthetic Packs (except More Zombies) + fix(files): formatting of packs.json #88

Closed
wants to merge 2 commits into from

Conversation

NSPC911
Copy link
Contributor

@NSPC911 NSPC911 commented Jun 19, 2024

Packs Added:

  • Accurate Scaffolding
  • Fencier Fences
  • Consistent Bamboo Planks
  • Allay Elytra

Combinations Added:

  • Accurate Scaffolding and Unobtrusive Scaffolding

Unofficial Issues Fixed:

  • Added missing comma at line 1070
  • Renamed all occurrences of "pack_name" to "name"

Official Issues Fixed:

By checking the following boxes with an X, you ensure that:

  • The pack was tested in-game in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

NSPC911 added 2 commits June 19, 2024 17:34
4 Packs:
Accurate Scaffolding
Consistent Bamboo Planks
Allay Elytra
Fencier Fences

1 Combination:
Accurate Scaffolding and Unobtrusive Scaffolding
Fix for the previous pull request that may or may not have caused issues._.
@NSPC911 NSPC911 closed this Jun 19, 2024
@NSPC911 NSPC911 deleted the aesthetic/all branch June 19, 2024 09:51
@NSPC911
Copy link
Contributor Author

NSPC911 commented Jun 19, 2024

smh i renamed the branch, didnt delete it

@NSPC911 NSPC911 changed the title feat(files): All Aesthetic Packs (except More Zombies) + fix(files): formatting of packs.json [ignore] feat(files): All Aesthetic Packs (except More Zombies) + fix(files): formatting of packs.json Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant