Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stage checking #278

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Fix stage checking #278

merged 7 commits into from
Oct 11, 2024

Conversation

a-ws-m
Copy link
Contributor

@a-ws-m a-ws-m commented Jan 31, 2024

Quick PR that solves #272 . I forgot I'd done this a while ago!

@orbeckst
Copy link
Member

closing and opening to cycle CI

@orbeckst orbeckst closed this Aug 19, 2024
@orbeckst orbeckst reopened this Aug 19, 2024
@orbeckst
Copy link
Member

orbeckst commented Oct 9, 2024

cyle CI (after re-enabling)

@orbeckst orbeckst closed this Oct 9, 2024
@orbeckst orbeckst reopened this Oct 9, 2024
@orbeckst orbeckst linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (c719914) to head (3c0b00c).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #278      +/-   ##
===========================================
+ Coverage    81.65%   82.39%   +0.74%     
===========================================
  Files           15       15              
  Lines         2017     2017              
  Branches       310      310              
===========================================
+ Hits          1647     1662      +15     
+ Misses         275      262      -13     
+ Partials        95       93       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix & sorry for the long delay!

@orbeckst orbeckst self-assigned this Oct 10, 2024
- add tests for mdpow.restart
- clarified docs for Journal and Journalled
- update CHANGES
@orbeckst orbeckst merged commit a0ecece into Becksteinlab:develop Oct 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulation stages cannot be restarted in case of an error
2 participants