Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error early when pattern var is not found #1660

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/scanner/detectors/customrule/filters/filters.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package filters

import (
"fmt"
"regexp"
"slices"
"strconv"
Expand Down Expand Up @@ -203,6 +204,9 @@ func (filter *Rule) Evaluate(
patternVariables variableshape.Values,
) (*Result, error) {
node := patternVariables.Node(filter.Variable)
if node == nil {
return nil, fmt.Errorf("couldn't find node for var %s", filter.Variable.Name())
}
detections, err := detectorContext.Scan(node, filter.Rule, filter.TraversalStrategy)
if err != nil {
return nil, err
Expand Down
Loading