Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read from config file for ignore migrate #1223

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Aug 28, 2023

Description

Read options from config file (if present) when migrating ignores. See discussion for further context: #1222 (review)

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested review from gotbadger and didroe August 28, 2023 15:29
pkg/commands/ignore.go Outdated Show resolved Hide resolved
@elsapet elsapet force-pushed the feat/read-from-config-file-for-ignore-migrate branch 2 times, most recently from 39d9e04 to e198f74 Compare August 29, 2023 08:01
@elsapet elsapet force-pushed the feat/read-from-config-file-for-ignore-migrate branch from e198f74 to 5f9c6d1 Compare August 29, 2023 08:29
@elsapet elsapet requested a review from didroe August 29, 2023 08:49
@elsapet elsapet merged commit e674387 into main Aug 29, 2023
8 checks passed
@elsapet elsapet deleted the feat/read-from-config-file-for-ignore-migrate branch August 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants