Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle empty list to scan for orchestrator #1209

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: handle empty list to scan for orchestrator #1209

merged 1 commit into from
Aug 25, 2023

Conversation

cfabianski
Copy link
Collaborator

Description

When performing a diff scan, you might end up with a branch that contains only new files. The orchestrator would hang in such circumstances.

closes #1205

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@cfabianski cfabianski marked this pull request as ready for review August 25, 2023 09:58
@cfabianski cfabianski requested a review from didroe August 25, 2023 10:05
@cfabianski cfabianski merged commit 1601958 into main Aug 25, 2023
5 checks passed
@cfabianski cfabianski deleted the fix/1205-empty-diff-hangs branch August 25, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proces hang when running DIFF_BASE_BRANCH with no file change
2 participants
@cfabianski @didroe