Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: example setup for circle ci #1207

Merged
merged 5 commits into from
Aug 25, 2023
Merged

docs: example setup for circle ci #1207

merged 5 commits into from
Aug 25, 2023

Conversation

gotbadger
Copy link
Contributor

Description

Example setup for Circle CI

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger changed the title doc: example setup for circle ci docs: example setup for circle ci Aug 24, 2023
Copy link
Contributor

@gmontard gmontard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion:

  • Split doc in two for both "main branch" and "pull request" integration

Otherwise LGTM

Copy link
Contributor

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo, and small suggestion, but otherwise looks good!

docs/guides/ci-setup.md Outdated Show resolved Hide resolved
docs/guides/ci-setup.md Outdated Show resolved Hide resolved
Copy link
Contributor

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo but looks great

docs/guides/ci-setup.md Outdated Show resolved Hide resolved
@gotbadger gotbadger merged commit 9d3698f into main Aug 25, 2023
5 checks passed
@gotbadger gotbadger deleted the doc/circle-ci branch August 25, 2023 09:21
gotbadger added a commit that referenced this pull request Aug 25, 2023
* docs: example setup for circle ci

* docs: Update docs/guides/ci-setup.md

Co-authored-by: elsapet <[email protected]>

* Update docs/guides/ci-setup.md

Co-authored-by: elsapet <[email protected]>

* docs: add basic example for CircleCI

* Update docs/guides/ci-setup.md

Co-authored-by: elsapet <[email protected]>

---------

Co-authored-by: elsapet <[email protected]>
elsapet added a commit that referenced this pull request Aug 25, 2023
* docs: example setup for circle ci

* docs: Update docs/guides/ci-setup.md

Co-authored-by: elsapet <[email protected]>

* Update docs/guides/ci-setup.md

Co-authored-by: elsapet <[email protected]>

* docs: add basic example for CircleCI

* Update docs/guides/ci-setup.md

Co-authored-by: elsapet <[email protected]>

---------

Co-authored-by: elsapet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document CircleCI CI/CD setup
3 participants