Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : First item on pagination #523

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

JeanneGrenet
Copy link
Contributor

@JeanneGrenet JeanneGrenet commented Sep 5, 2024

Describe your changes

closes #279

I put a condition on the firstItemOnPage props in Pagination component to display "Showing 0 to 0 of 0 results" instead of "Showing 1 to 0 of 0 results" when there is no result

Screenshots

Result
Capture d’écran du 2024-09-05 13-54-28
With these values
Capture d’écran du 2024-09-05 14-08-26

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

@JeanneGrenet JeanneGrenet self-assigned this Sep 5, 2024
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 1:15pm

Copy link

sonarcloud bot commented Sep 5, 2024

@yoannfleurydev yoannfleurydev merged commit e256bd7 into master Sep 6, 2024
7 checks passed
@yoannfleurydev yoannfleurydev deleted the fix/pagination-firstItemOnPage branch September 6, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Showing 1 to 0 of 0 results" in DataList footer
3 participants