Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/auto detect language #517

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Fix/auto detect language #517

merged 3 commits into from
Aug 5, 2024

Conversation

ivan-dalmet
Copy link
Member

Describe your changes

Allows language detection

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 11:21am

Copy link

sonarcloud bot commented Aug 4, 2024

Copy link
Member

@yoannfleurydev yoannfleurydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, looks good to me, I need to check it out though

@yoannfleurydev
Copy link
Member

OK in Firefox

Copy link
Member

@yoannfleurydev yoannfleurydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK in Arc

@yoannfleurydev yoannfleurydev merged commit eaad030 into master Aug 5, 2024
7 checks passed
@yoannfleurydev yoannfleurydev deleted the fix/auto-detect-language branch August 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants