feat: add field checkbox and fieldswitch #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yoannfleurydev
requested review from
DecampsRenan,
ivan-dalmet and
charlelisefouasse
|
Sonar is failing because of duplicated code in tests. We do not care about that 😄 |
Comment on lines
36
to
48
| <Controller | ||
| {...props} | ||
| render={({ field: { value, ...field } }) => ( | ||
| <Flex direction="column" gap={1.5}> | ||
| <Checkbox | ||
| isChecked={!!value} | ||
| isDisabled={props.isDisabled} | ||
| {...props.checkboxProps} | ||
| {...field} | ||
| /> | ||
| <FormFieldError /> | ||
| </Flex> | ||
| )} |
There was a problem hiding this comment.
We don't want to use FormFieldItem & FormFieldLabel like the other fields ? Same comment goes to FieldSwitch
There was a problem hiding this comment.
Another PR has changed the FormField API #505
yoannfleurydev
force-pushed
the
feat/more-fields
branch
from
6758025
to
d3258c1
Compare
update their theme
yoannfleurydev
force-pushed
the
feat/more-fields
branch
from
d3258c1
to
0b07555
Compare
ivan-dalmet
force-pushed
the
feat/more-fields
branch
from
a629432
to
2eccbc8
Compare
|
ivan-dalmet
approved these changes
Jul 22, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist
pnpm storybookcommand and everything is working(If you cannot update the french language, just let us know in the PR description)