Prevent error when closing meta tags modal (#311)

* Prevent error when closing meta tags modal * changelog
BeaconCMS · Dec 12, 2024 · 101973b · 101973b
1 parent 93122c1
commit 101973b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased
+
+### Fixes
+  - Fix "new meta tag" modal close event being sent to wrong target
+
 ## 0.3.0 (2024-12-05)
 
 ### Enhancements

diff --git a/lib/beacon/live_admin/live/meta_tags_component.ex b/lib/beacon/live_admin/live/meta_tags_component.ex
@@ -151,7 +151,7 @@ defmodule Beacon.LiveAdmin.MetaTagsComponent do
           </.form>
         </div>
 
-        <.modal :if={@new_attribute_modal_visible?} id="new-attribute-modal" show={true} on_cancel={JS.push("hide-new-attribute-modal")}>
+        <.modal :if={@new_attribute_modal_visible?} id="new-attribute-modal" show={true} on_cancel={JS.push("hide-new-attribute-modal", target: @myself)}>
           <.header>New meta tag attribute</.header>
 
           <.simple_form :let={f} for={%{}} as={:attribute} phx-target={@myself} phx-submit="save-new-attribute">