Update Curl wrapper to verify_peer like PHP stream contexts does #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to simulate a standard SoapClient BesimpleSoap should turn peer verification on by default in PHP 5.6+ and allow this setting to be changed (switched off if in testing, or switched on for what the majority of PHP <= 5.5 has to do manually)
|
I'd naturally prefer it to be set to true by default, but this is a more accurate alternative that acts the way SoapClient would. Not being able to turn on peer verification at all is a huge issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simulate a standard SoapClient
BesimpleSoap should turn peer verification on by default in PHP 5.6+
and allow this setting to be changed (switched off if in testing,
or switched on for what the majority of PHP <= 5.5 has to do manually)