Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation fix #111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

lordjancso
Copy link

Added the support of Sensio\Bundle\FrameworkExtraBundle\Configuration\Route and BeSimple\I18nRoutingBundle\Routing\Annotation\I18nRoute simultaneously.

@lordjancso
Copy link
Author

It solves issue #105 .

@albertboada
Copy link

albertboada commented Mar 5, 2018

This would be awesome, specially for Routes definitions in bundles that you can't / don't want to change. 👍

@lordjancso
Copy link
Author

ping @boekkooi

@lordjancso
Copy link
Author

ohh cmon...
any news to review and merge this one?

@LeCrook
Copy link

LeCrook commented Jul 28, 2018

Thank you ! I was confronting to the same problem and I had to change all the @route annotation in the vendors.......

@LeCrook
Copy link

LeCrook commented Jul 28, 2018

Any news on this PR ? This is really needy ! Thanks !

@lordjancso
Copy link
Author

@francisbesset will you merge this pr?

@LeCrook
Copy link

LeCrook commented Jul 28, 2018

ping @francisbesset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants