Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran support #23

Merged
merged 55 commits into from
Jul 9, 2024
Merged

Fortran support #23

merged 55 commits into from
Jul 9, 2024

Conversation

Bchass
Copy link
Owner

@Bchass Bchass commented Jun 5, 2024

Description

  • added asfortranarray()
  • update flags setter
  • update flags property
  • update ndarray to keep track of asfortranarray()

Related Issue

Closes: #14

Checklist

  • My changes pass all existing automated tests.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

Additional Notes

  • Add test cases
  • Update _strides_for_shape to support Fortran
  • Fix bug where _stides_for_shape will calculate C and F at the same time.
  • Update ndarray strides for Fortran
  • Update transpose
  • add f_cont and test
  • fix test_order_flags
  • fix buffersize calculations
  • fix _repr_ for Fortran
  • Update order option
  • Make sure order='F' sets F_CONTIGUOUS to True.
  • Update _get_step()

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (a297594) to head (8b60355).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   86.67%   86.01%   -0.67%     
==========================================
  Files           5        2       -3     
  Lines        1629      915     -714     
==========================================
- Hits         1412      787     -625     
+ Misses        217      128      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bchass
Copy link
Owner Author

Bchass commented Jun 6, 2024

Need to review changes for _strides_for_shape. Some test cases will fail for GH Actions but not locally.

@Bchass Bchass marked this pull request as ready for review July 9, 2024 01:33
@Bchass Bchass merged commit 8438527 into master Jul 9, 2024
21 of 22 checks passed
@Bchass Bchass deleted the support_fortran branch November 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fortran ordering
1 participant