Revert "Change from Xu to Lin and make it compatible with updates fro…

…m refactoring" This reverts commit ece1269. The correct paper is 10.1016/j.energy.2014.11.073.
BattMoTeam · Jun 18, 2024 · d2fce8e · d2fce8e
1 parent a12fee1
commit d2fce8e
Show file tree

Hide file tree

Showing 14 changed files with 62 additions and 40 deletions.
diff --git a/Documentation/parsets.rst b/Documentation/parsets.rst
@@ -20,10 +20,10 @@ listed in the directory :battmofile:`ParameterSets<ParameterData/ParameterSets>`
      - 2009
      - :cite:`Safari_2009`
      - :battmofile:`Safari2009<ParameterData/ParameterSets/Safari2009>`
-   * - Lin et al
+   * - Xu et al
      - 2015
      - :cite:`LIN2015633`
-     - :battmofile:`Lin2015<ParameterData/ParameterSets/Lin2015>`
+     - :battmofile:`Xu2015<ParameterData/ParameterSets/Xu2015>`
 
 
 Otherwise, separate input json files corresponding to different part of a battery model are included in the directory

diff --git a/Documentation/refs.bib b/Documentation/refs.bib
@@ -110,15 +110,18 @@ @article{Chen2020DevelopmentModels
   doi =          {10.1149/1945-7111/ab9050}
 }
 
-@article{LIN2015633,
-  title =        {Thermal analysis of large-capacity LiFePO4 power batteries for electric vehicles},
-  journal =      {Journal of Power Sources},
-  volume =       294,
-  pages =        {633-642},
-  year =         2015,
-  issn =         {0378-7753},
-  doi =          {10.1016/j.jpowsour.2015.06.129},
-  author =       {Chunjing Lin and Sichuan Xu and Zhao Li and Bin Li and Guofeng Chang and Jinling Liu}
+@article{XU2015303,
+  title =	 {{A pseudo three-dimensional electrochemical–thermal
+                  model of a prismatic LiFePO4 battery during
+                  discharge process}},
+  journal =	 {Energy},
+  volume =	 {80},
+  pages =	 {303-317},
+  year =	 {2015},
+  issn =	 {0360-5442},
+  doi =		 {10.1016/j.energy.2014.11.073},
+  author =	 {Meng Xu and Zhuqian Zhang and Xia Wang and Li Jia
+                  and Lixin Yang}
 }
 
 @article{Safari_2009,

diff --git a/...yComponentParameters/celgard2500_Lin.json → ...ryComponentParameters/celgard2500_Xu.json b/...yComponentParameters/celgard2500_Lin.json → ...ryComponentParameters/celgard2500_Xu.json
diff --git a/...alProperties/Aluminium/aluminium_Lin.json → ...ialProperties/Aluminium/aluminium_Xu.json b/...alProperties/Aluminium/aluminium_Lin.json → ...ialProperties/Aluminium/aluminium_Xu.json
diff --git a/...MaterialProperties/Copper/copper_Lin.json → .../MaterialProperties/Copper/copper_Xu.json b/...MaterialProperties/Copper/copper_Lin.json → .../MaterialProperties/Copper/copper_Xu.json
diff --git a/ParameterData/MaterialProperties/LFP/LFP.json b/ParameterData/MaterialProperties/LFP/LFP.json
@@ -9,7 +9,7 @@
     "guestStoichiometry0": 0.999,
     "chargeTransferCoefficient": 0.5,
     "openCircuitPotential": {"type": "function",
-                             "functionname": "computeOCPFunc_LFP_Lin",
+                             "functionname": "computeOCPFunc_LFP_Xu",
                              "argumentlist" : ["concentration", "temperature", "cmax"]
                             }
 }
diff --git a/...alProperties/LFP/computeOCPFunc_LFP_Lin.m → ...ialProperties/LFP/computeOCPFunc_LFP_Xu.m b/...alProperties/LFP/computeOCPFunc_LFP_Lin.m → ...ialProperties/LFP/computeOCPFunc_LFP_Xu.m
@@ -1,6 +1,6 @@
-function [OCP, dUdT] = computeOCPFunc_LFP_Lin(c, T, cmax)
+function [OCP, dUdT] = computeOCPFunc_LFP_Xu(c, T, cmax)
 %% TODO : implement function model to avoid reading
-
+    
     stoc = c./cmax;
 
     data = [0.00, 4.1433
@@ -65,5 +65,5 @@
             9.89111e-1, -3.11393e-5];
 
     dUdT = interpTable(data(:, 1), data(:, 2), stoc);
-
+    
 end
diff --git a/...ata/MaterialProperties/LiC6/LiC6_Lin.json → ...Data/MaterialProperties/LiC6/LiC6_Xu.json b/...ata/MaterialProperties/LiC6/LiC6_Lin.json → ...Data/MaterialProperties/LiC6/LiC6_Xu.json
@@ -1,14 +1,14 @@
 {
     "saturationConcentration": 31540,
-    "volumetricSurfaceArea": 142372,
+    "volumetricSurfaceArea": 142372, 
     "density": 1852,
     "numberOfElectronsTransferred" : 1,
     "activationEnergyOfReaction": 4000,
     "reactionRateConstant": 1.76e-11,
     "guestStoichiometry100": 0.51873811,
     "guestStoichiometry0": 0.001,
     "openCircuitPotential": {"type": "function",
-                             "functionname": "computeOCPFunc_LiC6_Lin",
+                             "functionname": "computeOCPFunc_LiC6_Xu",
                              "argumentlist" : ["concentration", "temperature", "cmax"]
                             }
 }
diff --git a/...Properties/LiC6/computeOCPFunc_LiC6_Lin.m → ...lProperties/LiC6/computeOCPFunc_LiC6_Xu.m b/...Properties/LiC6/computeOCPFunc_LiC6_Lin.m → ...lProperties/LiC6/computeOCPFunc_LiC6_Xu.m
@@ -1,6 +1,6 @@
-function [OCP, dUdT] = computeOCPFunc_LiC6_Lin(c, T, cmax)
+function [OCP, dUdT] = computeOCPFunc_LiC6_Xu(c, T, cmax)
 %% TODO : implement function model to avoid reading
-
+    
     data = [0.00, 1.28683
             0.01, 0.65272
             0.02, 0.52621
@@ -34,7 +34,7 @@
     stoc = c./cmax;
 
     OCP = interpTable(data(:, 1), data(:, 2), stoc);
-
+    
     data = [0.01049, 3.00E-04
             0.03146, 2.47E-04
             0.05244, 1.95E-04

diff --git a/...ons/computeDiffusionCoefficientFunc_Lin.m → ...ions/computeDiffusionCoefficientFunc_Xu.m b/...ons/computeDiffusionCoefficientFunc_Lin.m → ...ions/computeDiffusionCoefficientFunc_Xu.m
@@ -1,16 +1,16 @@
-function D = computeDiffusionCoefficientFunc_Lin(c, T)
-
+function D = computeDiffusionCoefficientFunc_Xu(c, T)
+    
     % Calculate diffusion coefficients constant for the diffusion coefficient calculation
-    cnst = [ -4.43, -54;
+    cnst = [ -4.43, -54; 
              -0.22, 0.0 ];
 
     Tgi = [ 229; 5.0 ];
-
+    
     % Diffusion coefficient, [m^2 s^-1]
     %Removed 10⁻⁴ otherwise the same
     D = 10 .^ ( ( cnst(1,1) + cnst(1,2) ./ ( T - Tgi(1) - Tgi(2) .* c .* 1e-3) + cnst(2,1) .* ...
                           c .* 1e-3) );
-
+    
 end
 
 

diff --git a/.../computeElectrolyteConductivityFunc_Lin.m → ...s/computeElectrolyteConductivityFunc_Xu.m b/.../computeElectrolyteConductivityFunc_Lin.m → ...s/computeElectrolyteConductivityFunc_Xu.m
@@ -1,12 +1,12 @@
-function conductivity = computeElectrolyteConductivityFunc_Lin(c, T)
-
+function conductivity = computeElectrolyteConductivityFunc_Xu(c, T)
+    
     conductivityFactor = 1e-4;
-
+    
     %cnst = [-10.5   , 0.074    , -6.96e-5; ...
     %        0.668e-3, -1.78e-5 , 2.80e-8; ...
-    %        0.494e-6, -8.86e-10, 0];
-
-
+    %        0.494e-6, -8.86e-10, 0];            
+            
+    
     % Ionic conductivity, [S m^-1]
     %conductivity = conductivityFactor.* c .*( polyval(cnst(end:-1:1,1),c) + polyval(cnst(end:-1:1,2),c) .* T + ...
     %                                          polyval(cnst(end:-1:1,3),c) .* T.^2).^2;
@@ -16,7 +16,7 @@
         0.26235e-3.*c-9.3063e-6.*c.*T+ ...
         8.069e-9.*c.*T.^2+ ...
         2.2002e-7.*c.^2-1.765e-10.*T.*c.^2);
-
+    
 end
 
 

diff --git a/...s/OrganicLiPF6Solutions/orgLiPF6_Lin.json → ...es/OrganicLiPF6Solutions/orgLiPF6_Xu.json b/...s/OrganicLiPF6Solutions/orgLiPF6_Lin.json → ...es/OrganicLiPF6Solutions/orgLiPF6_Xu.json
@@ -5,17 +5,35 @@
   "initialConcentration": {"value" : 1,
                            "unit" : "mol/litre"},
   "Conductivity" : {"type": "function",
-                    "functionname" : "computeElectrolyteConductivityFunc_Lin",
+                    "functionname" : "computeElectrolyteConductivityFunc_Xu",
                     "argumentlist" : ["concentration", "temperature"]
                    },
   "DiffusionCoefficient" : {"type": "function",
-                            "functionname" : "computeDiffusionCoefficientFunc_Lin",
+                            "functionname" : "computeDiffusionCoefficientFunc_Xu",
                             "argumentlist" : ["concentration", "temperature"]
                            },
+<<<<<<< HEAD:ParameterData/MaterialProperties/OrganicLiPF6Solutions/orgLiPF6_Lin.json
   "species": { "chargeNumber": 1,
                "transferenceNumber": 0.2594,
                "nominalConcentration": 1000},
   "Separator": { "filename": "ParameterData/BatteryComponentParameters/celgard2500_Lin.json",
+||||||| ece1269c (Change from Xu to Lin and make it compatible with updates from refactoring):ParameterData/MaterialProperties/OrganicLiPF6Solutions/orgLiPF6_Lin.json
+  "compnames": [
+    "Li",
+    "PF6"
+  ],
+  "sp": { "z": 1,
+          "t": 0.2594},
+  "Separator": { "filename": "ParameterData/BatteryComponentParameters/celgard2500_Lin.json",
+=======
+  "compnames": [
+    "Li",
+    "PF6"
+  ],
+  "sp": { "z": 1,
+          "t": 0.2594},
+  "Separator": { "filename": "ParameterData/BatteryComponentParameters/celgard2500_Xu.json",
+>>>>>>> parent of ece1269c (Change from Xu to Lin and make it compatible with updates from refactoring):ParameterData/MaterialProperties/OrganicLiPF6Solutions/orgLiPF6_Xu.json
                  "isFile": true },
   "BruggemanCoefficient": 1.5
 }
diff --git a/ParameterData/ParameterSets/Lin2015/lfp.json → ParameterData/ParameterSets/Xu2015/lfp.json b/ParameterData/ParameterSets/Lin2015/lfp.json → ParameterData/ParameterSets/Xu2015/lfp.json
@@ -23,7 +23,7 @@
 	"electricalConductivity": 2,
 	"Interface": {
           "isFile": true,
-          "filename": "ParameterData/MaterialProperties/LiC6/LiC6_Lin.json"
+          "filename": "ParameterData/MaterialProperties/LiC6/LiC6_Xu.json"
 	},
 	"diffusionModelType" : "full",
 	"SolidDiffusion" : {
@@ -36,7 +36,7 @@
     },
     "CurrentCollector": {
       "isFile": true,
-      "filename": "ParameterData/MaterialProperties/Copper/copper_Lin.json"
+      "filename": "ParameterData/MaterialProperties/Copper/copper_Xu.json"
     }
   },
   "PositiveElectrode": {
@@ -62,15 +62,16 @@
     },
     "CurrentCollector": {
       "isFile": true,
-      "filename": "ParameterData/MaterialProperties/Aluminium/aluminium_Lin.json"
+      "filename": "ParameterData/MaterialProperties/Aluminium/aluminium_Xu.json"
     }
   },
   "Electrolyte": {
-    "filename": "ParameterData/MaterialProperties/OrganicLiPF6Solutions/orgLiPF6_Lin.json",
+    "filename": "ParameterData/MaterialProperties/OrganicLiPF6Solutions/orgLiPF6_Xu.json",
     "isFile": true
   },
   "Separator": {
-    "filename": "ParameterData/BatteryComponentParameters/celgard2500_Lin.json",
+    "comment": "Specification of separator not found in reference",
+    "filename": "ParameterData/BatteryComponentParameters/celgard2500.json",
     "isFile": true
   },
   "ThermalModel": {

diff --git a/Tests/TestExamples/TestJsonFiles.m b/Tests/TestExamples/TestJsonFiles.m
@@ -7,7 +7,7 @@
         jsonDataSet = {
             fullfile('ParameterData', 'BatteryCellParameters', 'LithiumIonBatteryCell'      , 'lithium_ion_battery_nmc_graphite.json'), ...
             fullfile('ParameterData', 'ParameterSets'        , 'Chen2020'                   , 'chen2020_lithium_ion_battery.json')    , ...
-            fullfile('ParameterData', 'ParameterSets'        , 'Lin2015'                    , 'lfp.json')                             , ...
+            fullfile('ParameterData', 'ParameterSets'        , 'Xu2015'                     , 'lfp.json')                             , ...
             fullfile('Examples'     , 'JsonDataFiles'        , 'p2d_40_jl.json')            , ...
             fullfile('Examples'     , 'JsonDataFiles'        , 'p2d_40_jl_ud.json')         , ...
             fullfile('Examples'     , 'JsonDataFiles'        , 'p2d_40.json')               , ...