Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement #2241 (custom config file during install) #2242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvk
Copy link

@mvk mvk commented Feb 26, 2024

  • update install.sh/uninstall.sh
  • update README.md

Description

  • added handling of overriding of CONFIG_FILE if BASH_IT_CONFIG_FILE is passed to install.sh/uninstall.sh

Motivation and Context

this allows not touching user's bash config file, making it easier to detect regressions or compare 2 config files.

#2241

How Has This Been Tested?

the change is pretty trivial, ran BASH_IT_CONFIG_FILE=.bashrc_bash_it ./install.sh resulted in created fle, bashrc untouched.

linux: rhel7, ubuntu 22, mac.

doubt there are any other side-effects, please review though.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

- update `install.sh` & `uninstall.sh`
- update `README.md`

Signed-off-by: Max Kovgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant